Drop cuda 11 usages #19386
Merged
Drop cuda 11 usages #19386
+138
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
the
improvement
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
Python
bdice
reviewed
Jul 16, 2025
| @@ -104,8 +104,8 @@ def default_memory_resource( | |||
| ): | |||
| raise ComputeError( | |||
| "GPU engine requested, but incorrect cudf-polars package installed. " | |||
| "If your system has a CUDA 11 driver, please uninstall `cudf-polars-cu12` " | |||
| "and install `cudf-polars-cu11`" | |||
| "If your system has a CUDA `x` driver, please uninstall `cudf-polars-cu12` " | |||
There was a problem hiding this comment.
How can this error be reached? Do we need this to say “Requires CUDA 12+” instead of recommending a reinstall?
I tried to trace down how this code is reached. Is it one of these two paths? https://github.com/search?q=repo%3Arapidsai%2Frmm+%22not+supported+with+this+CUDA+driver%2Fruntime+version%22&type=code
There was a problem hiding this comment.
Yes, that is the paths. I updated the error message.
ttnghia
reviewed
Jul 16, 2025
Matt711
reviewed
Jul 16, 2025
TomAugspurger
approved these changes
Jul 17, 2025
Matt711
approved these changes
Jul 17, 2025
Comment on lines
-107
to
-108
| "If your system has a CUDA 11 driver, please uninstall `cudf-polars-cu12` " | ||
| "and install `cudf-polars-cu11`" |
bdice
approved these changes
Jul 17, 2025
Co-authored-by: Matthew Murray <[email protected]>
|
@ttnghia Can i get a java review on this? |
ttnghia
approved these changes
Jul 17, 2025
|
/merge |
rapids-bot
bot
merged commit 55ad793
into
rapidsai:branch-25.08
171 of 174 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to issue: #19381
Description
This PR drops cuda-11 usages in
cudfcodebase.Checklist