JNI Set RMM_LOG_LEVEL and RMM_LOG_ACTIVE_LEVEL to allow setting log level at compile time #19435
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vel at compile time Signed-off-by: Alessandro Bellina <[email protected]>
abellina
added
Spark
bdice
reviewed
Jul 18, 2025
| @@ -141,6 +141,18 @@ if(USE_GDS) | |||
| endif() | |||
| endif() | |||
|
|
|||
| # Set RMM logging level | |||
| set(RMM_LOGGING_LEVEL | |||
There was a problem hiding this comment.
There's a related conversation here about what should be precompiled in RMM here: rapidsai/rmm#1983 (comment)
It feels like these two topics might be solvable in similar ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have confusion from the customer side when they look at logs and see ERRORs from our pinned memory pool, since it is using a pooled_memory_resource that when exhausted we handle gracefully (here's a report NVIDIA/spark-rapids#13131):
The problem stems from us setting RMM_LOGGING_LEVEL in our cmake builds, but this is not getting propagated to RMM itself, somehow. I have been able to make this propagate, and silence the error @revans2 posted, but I am not 100% sure this is the right thing to do. Asking folks here for some help (@bdice) to check the CMakeLists change.
Description
Checklist