Skip to content

Remove constraints argument from rapids-generate-pip-constraints - #261

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
KyleFromNVIDIA:rapids-generate-pip-constraints-remove-output-argument
Oct 27, 2026
Merged

rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
KyleFromNVIDIA:rapids-generate-pip-constraints-remove-output-argument

Conversation

@KyleFromNVIDIA

Copy link
Copy Markdown
Member

With rapidsai/gha-tools#282 merged, we no longer
need the third constraints argument. Remove it.

Issue: rapidsai/build-planning#311

With rapidsai/gha-tools#282 merged, we no longer
need the third `constraints` argument. Remove it.

Issue: rapidsai/build-planning#311
@KyleFromNVIDIA
KyleFromNVIDIA requested a review from a team as a code owner October 26, 2026 16:13
@github-actions github-actions Bot added the ci label Oct 26, 2026
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 2108ec0 and 41fc204.

Files selected for processing: 1
  • ci/test_wheel.sh

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the Python package constraint configuration used in CI testing. This is an internal testing change and does not alter the application’s features or behavior for users.

The wheel test script calls rapids-generate-pip-constraints with test_python and ${PIP_CONSTRAINT}. It no longer passes the trailing constraints argument.

Changes: Wheel test constraints

Layer / File(s) Summary
Update constraint invocation
ci/test_wheel.sh
The constraint-generation command no longer passes the trailing constraints argument.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

  • rapidsai/nvforest#260: This PR adds the same argument to the same command, while this change removes it.

Suggested labels: improvement, non-breaking

Suggested reviewers: chyunsu3

Merge Risk: Minimal · up to 41fc2

The constraint-generation change preserves the wheel test's existing pip constraint workflow.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description explains why the third constraints argument is no longer needed and matches the changeset.
Title check Passed The title clearly and concisely describes the main change: removing the constraints argument from rapids-generate-pip-constraints.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 26, 2026
@jameslamb

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit ea15108 into rapidsai:main Oct 27, 2026
92 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants