Remove fmt 11.0.2 patch #695

Description

RAPIDS updated to fmt 11.0.2 in #689. To do that, rapids-cmake project took on a patch to suppress warnings from nvcc about a bit of code in fmt being unreachable.

references:

• update fmt (to 11.0.2) and spdlog (to 1.14.1) #689 (comment)
• Update fmt (to 11.0.2) and spdlog (to 1.14.1). NVIDIA/raft#2433 (comment)

That patch should be removed and fixes upstreamed to the appropriate places (e.g. RAPIDS code, fmt, nvcc).

Benefits of this work

• fixes one or more bugs that might otherwise slow development in the future
• no patch = no vendoring for conda packages ([BUG] Conda package for rmm 24.04.00 clobbering files from fmt and spdlog rmm#1528 (comment))

Acceptance Criteria

Approach

First, try to reproduce the error. That could probably be done like this (haven't re-tested as of this writing):

• remove the patch at

  rapids-cmake/rapids-cmake/cpm/versions.json

  Lines 30 to 35 in 3815fab

  	"patches": [
  	{
  	"file": "fmt/fix_11_0_2_unreachable_loop.diff",
  	"issue": "fmt 11.0.2 produces a warning about an unreachable loop when compiled with nvcc"
  	}
  	]

• follow https://docs.rapids.ai/api/rapids-cmake/nightly/basics/#overriding-rapids-cmake to point cudf's CMake at it
• run build-all in the cudf pip devcontainer
  • *that's one of the places the unreachable-loop error was noticed: Update fmt (to 11.0.2) and spdlog (to 1.14.1). NVIDIA/cudf#16806
  • *it was also noticed in raft C++ conda builds:

Try to narrow down:

• version(s) of NVCC?
• minimal, reproducible example (more minimal than "compile all of cudf")

Submit fixes that'd allow the fmt patch in rapids-cmake to be removed.

Notes

Would also help with these:

• Treat clobber warnings as errors for conda builds build-planning#54
• [BUG] Conda package for rmm 24.04.00 clobbering files from fmt and spdlog rmm#1528