Skip to content

Implemented device_uvector's reverse iterators #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2025

Conversation

lamarrr
Copy link
Contributor

@lamarrr lamarrr commented Jun 4, 2025

Description

This pull request implements the reverse iterators for the device_uvector type.
Closes #1326

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Jun 4, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@lamarrr lamarrr changed the title Implemented device_uvector::rbegin, cbegin, rend, and crend Implemented device_uvector::rbegin, crbegin, rend, and crend Jun 4, 2025
@lamarrr lamarrr force-pushed the uvector-begin-end branch from 0962511 to 5009ffb Compare June 4, 2025 11:47
@lamarrr lamarrr marked this pull request as ready for review June 4, 2025 11:49
@lamarrr lamarrr requested a review from a team as a code owner June 4, 2025 11:49
@lamarrr lamarrr requested review from harrism and wence- June 4, 2025 11:49
@lamarrr lamarrr changed the title Implemented device_uvector::rbegin, crbegin, rend, and crend Implemented device_uvector's reverse iterators Jun 4, 2025
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Maybe test direction a bit more?

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a helpful addition. I would add some of the tests that Mark and I proposed in the comments, then we can merge this.

@bdice bdice added feature request New feature or request non-breaking Non-breaking change labels Jun 10, 2025
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to block merge since this PR has two approvals but also an open request for new tests.

@lamarrr lamarrr requested review from vyasr, harrism and bdice June 17, 2025 18:48
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for contributing this.

@bdice
Copy link
Contributor

bdice commented Jun 17, 2025

/merge

@rapids-bot rapids-bot bot merged commit 0016ffb into rapidsai:main Jun 17, 2025
50 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in RMM Project Board Jun 17, 2025
@lamarrr lamarrr deleted the uvector-begin-end branch June 17, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support for rbegin / rend on rmm::device_uvector
4 participants