This repository was archived by the owner on Nov 22, 2017. It is now read-only.
Changing the config file should not dirty the repo.#339
Open
ConsoleCatzirl wants to merge 1 commit intorashidkpc:kibana-rubyfrom
Open
Changing the config file should not dirty the repo.#339ConsoleCatzirl wants to merge 1 commit intorashidkpc:kibana-rubyfrom
ConsoleCatzirl wants to merge 1 commit intorashidkpc:kibana-rubyfrom
Conversation
The config file contains implementation details that may change from one deployment to another, and changing these values should not dirty the git repo. This can be done by moving the config file to a sample file, and ignoring the actual config file in git. This means that a new step is added to the install process: copying the sample file to the actual location before making any site-specific changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config file contains implementation details that may change from
one deployment to another, and changing these values should not dirty
the git repo.
This can be done by moving the config file to a sample file, and
ignoring the actual config file in git. This means that a new step
is added to the install process: copying the sample file to the actual
location before making any site-specific changes.
This change is