-
Notifications
You must be signed in to change notification settings - Fork 253
Fix cmake handling of paths with spaces #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kilograham I guess when the dust has settled on this PR, we'll also want to "upstream" these changes to https://github.com/raspberrypi/pico-sdk/blob/develop/external/pico_sdk_import.cmake and https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/main/portable/ThirdParty/GCC/RP2040/FreeRTOS_Kernel_import.cmake ? |
Okay, latest commit should mean this is ready to merge. Only question left is whether we should keep double quotes for |
Please remove the quotes for cmake_version and pico_sdk_version_major - they aren't paths, and shouldn't have spaces in. After you've done that, please squash your commits and add a signed-off-by line:
The freertos cmake file is from upstream - https://github.com/FreeRTOS/FreeRTOS-Kernel - and the pico-sdk import is from our repo. |
Signed-off-by: TankedThomas <[email protected]>
a15bcb8
to
08ea74c
Compare
Okay, I removed those quotes, also from Commits are squashed and signed off. Should be ready to merge now. Quick note: upstream has other changes and was updated a month ago vs. 4 months ago in this repo. Should those be merged too? It'll probably require some extra changes to the upstream version too. |
Thanks. I only update external cmake files if there's a dependency break - which won't happen if I don't move the submodule pointers. If any changes to those files land upstream and I need to update them, I'll do that as and when necessary. I've no objection to a different fix landing in upstream repos. |
My Pico SDK filepath uses spaces, which caused problems with the cmake files. I know it's not ideal to have pathname spaces, but putting double quotes around all the variables in the cmake files should fix this.
I'm not aware of any downsides to this change but I'm no expert on the subject. I did test compiling after the changes and it seems to work fine.
There are two commits because I forgot to include the other two cmake files initially.