v2 dwc2 DMA alignment_buffer handling #6923
Merged
+20
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This incorrectly matches on urb->setup_packet instead of checking the pipe type, so recycled URBs were incorrectly matched. A more comprehensive fix is forthcoming. This reverts commit 2f27224. Signed-off-by: Jonathan Bell <[email protected]>
The version of the dwc-otg core used in BCM2835 through BCM2712 only does whole-word writes, as well as needing the documented requirement for DMA buffers to start on a word boundary. Also, the alignment method used in the dwc2 driver doesn't handle the case where the URB has the NO_TRANSFER_DMA_MAP flag set, so reject buffers that have unaligned DMA start addresses. At least one whole page should be mapped, so the BCM283x whole-word-write bug should be benign in this case. Signed-off-by: Jonathan Bell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidate fix for #6911
Both UVC cameras and USB mass-storage are now functional on CM5.
All the Broadcom SoCs use the same SNPS core version (2.80a) so the hardware length bug is present in each.