Replace .dll.a libusb libraries with .a #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
approved these changes
Aug 29, 2024
will-v-pi
added a commit
that referenced
this pull request
Apr 15, 2025
Add `PICOTOOL_LIBUSB_ALLOW_DLL` variable to switch back to the old behaviour, prior to #126
will-v-pi
added a commit
that referenced
this pull request
Apr 15, 2025
Add `PICOTOOL_LIBUSB_ALLOW_DLL` variable to switch back to the old behaviour, prior to #126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, with the latest libusb-1.0.27 downloaded, the
find_librarycommand returns the.dll.alibraries, which refer to the dynamic.dlllibraries in a separate folder. This means picotool compiles fine, but when run it throws an error that it can't findlibusb-1.0.dll. It will only run iflibusb-1.0.dllis in a location Windows searches for.dlls, such as the same directory as the executable, or in the path.Fix this by replacing
.dll.awith.ain the output fromfind_library- this links picotool against the staticlibusb-1.0.alibrary, so doesn't require any external files.