Merge develop into master #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid importing AppKit when building for visionOS
Initial support for visionOS
…e project, updated to use SPM instead. Simplified Package.swift.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges develop into master while updating the highlighter library, removing outdated Pod integration, and renaming directories and resource paths to support new asset processing. Key changes include:
- Removal of legacy Pod-specific files (LICENSE, podspec, Xcode schemes, etc.) and old [email protected].
- Updates in Package.swift to change source paths from "Pod/Classes" to "src/classes" and to process assets using new directives.
- Updates in the Example project, including a dependency import change and Interface Builder upgrades in LaunchScreen.xib.
Reviewed Changes
Copilot reviewed 18 out of 372 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Pod/Assets/styles/a11y-dark.min.css | Removed outdated theme file. |
| Pod/Assets/Highlighter/LICENSE | Removed legacy license file from Pod integration. |
| [email protected] | Removed outdated Swift package configuration. |
| Package.swift | Updated project paths, resource processing, and asset references. |
| Highlightr/* | Removal of legacy iOS/macOS target files (Info.plist, headers). |
| Highlightr.xcodeproj/* | Removed old Xcode schemes and workspace settings. |
| Highlightr.podspec | Podspec removed due to dropping Pod integration. |
| Example/Highlightr/SampleCode.swift | Updated dependency import from ActionSheetPicker_3_0 to CoreActionSheetPicker. |
| Example/Highlightr/Base.lproj/LaunchScreen.xib | Updated XIB for new Interface Builder tools and layout adjustments. |
| Example/Highlightr.xcodeproj/project.pbxproj | Revised project build settings and swift package references. |
| CHANGELOG.md | Updated release notes to reflect v2.3.0 changes. |
Files not reviewed (2)
- Example/Highlightr.xcworkspace/contents.xcworkspacedata: Language not supported
- Highlightr.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Language not supported
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated highlighter.js to v11.11.1, removed Pod integration, made code more defensive and added a bunch of new themes.