Skip to content

Remove const declaration in bn-to-num#4

Merged
mikolalysenko merged 1 commit intorat-nest:masterfrom
jth-:master
Mar 30, 2017
Merged

Remove const declaration in bn-to-num#4
mikolalysenko merged 1 commit intorat-nest:masterfrom
jth-:master

Conversation

@jth-
Copy link
Copy Markdown
Contributor

@jth- jth- commented Mar 28, 2017

Remove const declaration in favor of a var so as not to throw an error in older webkit browsers.

https://bugs.webkit.org/show_bug.cgi?id=161464

@mikolalysenko mikolalysenko merged commit ff5ada2 into rat-nest:master Mar 30, 2017
@mikolalysenko
Copy link
Copy Markdown
Member

Sorry about that, wasn't paying attention

@ashnur
Copy link
Copy Markdown
Contributor

ashnur commented Mar 31, 2017

Interesting lesson for me that this turned out to be a problem.

@rreusser
Copy link
Copy Markdown

FWIW we added an eslint pass with ecmaVersion: 5 and no other rules. Quick n easy way to assert ES5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants