Update to use new SocketServer API with react/socket v1.9+
#1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset updates to use the new
SocketServerAPI available with react/socket v1.9+. This is part 12 of reviving Ratchet as discussed in #1054, unblocking more future progress.This is mostly done to avoid using deprecated APIs (reactphp/socket#263 and upcoming reactphp/socket#314) and should not have any visible effect for consumers of this package. Similar to #1105 and #1095 and #1098, this was implemented in a way to use the newer API when available and the legacy APIs as a fallback. The test suite confirms this has full test coverage and does not otherwise affect any of the existing tests.
Overall, this required quite a massive effort. If you want to support this project, please consider sponsoring @reactphp ❤️
Builds on top of reactphp/socket#263, #1105, #1098, #1095, #1088, #485 and others, one step closer to reviving Ratchet as discussed in #1054
Resolves / closes #917
Resolves / closes #1038