Fix division by zero#117
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR updates Float62’s division behavior to avoid undefined/panicking integer operations when dividing by zero, and aligns integer-division-by-zero results with IEEE-754 float semantics (±∞ for nonzero / 0, NaN for 0 / 0).
Changes:
- Prevent modulo-by-zero by guarding the integer fast-path with
y != 0beforex % y. - For integer division by zero, fall back to float division (
x as f64 / y as f64) to produce ±∞/NaN instead of a hardcoded NaN. - Update division-by-zero tests to assert ±∞ and NaN outcomes.
Comments suppressed due to low confidence (1)
src/f62.rs:305
Float62::from_integeronly reliably encodes 63-bit signed integers (seebox_integerdocs). In the integer fast-path,x / ycan produce a quotient outside that range (e.g.x == -(1<<62)andy == -1yields1<<62). Boxing that value wraps and decodes to the wrong integer. Consider range-checking the quotient and falling back to float when it is not representable as an integer payload (and add a regression test for this boundary case).
if y != 0 && x % y == 0 {
Self::from_integer(x / y)
} else {
Self::from_float(x as f64 / y as f64)
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.