[RLlib-contrib] Alpha Zero#36736
Merged
sven1977 merged 9 commits intoray-project:masterfrom Oct 4, 2023
Merged
Conversation
Signed-off-by: Avnish <avnishnarayan@gmail.com>
…b_contrib_alpha_zero Signed-off-by: Avnish <avnishnarayan@gmail.com>
Signed-off-by: Avnish <avnishnarayan@gmail.com>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
stale
bot
removed
the
stale
Signed-off-by: Sven Mika <svenmika1977@gmail.com>
Signed-off-by: Sven Mika <svenmika1977@gmail.com>
Signed-off-by: Sven Mika <svenmika1977@gmail.com>
Zandew
pushed a commit
to Zandew/ray
that referenced
this pull request
Oct 10, 2023
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Signed-off-by: Victor <vctr.y.m@example.com>
sorgfresser
reviewed
Sep 15, 2024
| value = leaf.reward | ||
| else: | ||
| child_priors, value = self.model.compute_priors_and_value(leaf.obs) | ||
| if self.add_dirichlet_noise: |
There was a problem hiding this comment.
Are we sure we want to add dirichlet noise to every child prior, not only to the ones starting in the root node? This behaviour differs from the one proposed in the paper and the open spiel implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avnish avnishnarayan@gmail.com
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.