Skip to content

[Data] Hard deprecate DatasetPipeline#40129

Merged
bveeramani merged 38 commits intoray-project:masterfrom
bveeramani:remove-dataset-pipeline
Oct 13, 2023
Merged

[Data] Hard deprecate DatasetPipeline#40129
bveeramani merged 38 commits intoray-project:masterfrom
bveeramani:remove-dataset-pipeline

Conversation

@bveeramani
Copy link
Member

@bveeramani bveeramani commented Oct 5, 2023

Stacked on:

Why are these changes needed?

Fixes #40166.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

amogkam and others added 7 commits September 28, 2023 17:30
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
…taset-config

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani mentioned this pull request Oct 5, 2023
6 tasks
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
…ve-dataset-pipeline

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bveeramani, great job!

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
…ve-dataset-pipeline

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@scottjlee scottjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! so we will not be removing the DatasetPipeline class completely for now, just raising the deprecation warning?

@c21
Copy link
Contributor

c21 commented Oct 12, 2023

so we will not be removing the DatasetPipeline class completely for now, just raising the deprecation warning?

The only thing I am worried about is the usage of DatasetPipeline.from_iterable. I want to avoid the situation that Python throws the module/class not found, and people shocked about it. Any blocker if we keep the DatasetPipeline class around? All actual code inside DatasetPipeline is removed.

@bveeramani bveeramani merged commit 65ed62d into ray-project:master Oct 13, 2023
@bveeramani bveeramani deleted the remove-dataset-pipeline branch October 13, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Data] Deprecate DatasetPipeline

4 participants