Skip to content

[train] enable isort#40172

Merged
justinvyu merged 2 commits intoray-project:masterfrom
matthewdeng:train-isort
Oct 6, 2023
Merged

[train] enable isort#40172
justinvyu merged 2 commits intoray-project:masterfrom
matthewdeng:train-isort

Conversation

@matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Oct 6, 2023

Why are these changes needed?

Format the imports for better readability.

Changes:

  1. Enable isort for python/ray/train so that it will be formatted with ./scripts/format.sh.
  2. Run isort python/ray/train once.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng matthewdeng marked this pull request as ready for review October 6, 2023 02:49
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@justinvyu justinvyu merged commit e918a19 into ray-project:master Oct 6, 2023
Zandew pushed a commit to Zandew/ray that referenced this pull request Oct 10, 2023
Enable `isort` for `python/ray/train` so that it will be formatted with `./scripts/format.sh`.

---------

Signed-off-by: Matthew Deng <matt@anyscale.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Enable `isort` for `python/ray/train` so that it will be formatted with `./scripts/format.sh`.

---------

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants