Skip to content

[Dependencies] Remove typing_extensions#40336

Merged
pcmoritz merged 5 commits intoray-project:masterfrom
pcmoritz:remove-typing-extensions
Oct 17, 2023
Merged

[Dependencies] Remove typing_extensions#40336
pcmoritz merged 5 commits intoray-project:masterfrom
pcmoritz:remove-typing-extensions

Conversation

@pcmoritz
Copy link
Contributor

Why are these changes needed?

Now that we drop Python 3.7 support for Ray 2.8, we can remove the typing_extensions dependency.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Collaborator

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@pcmoritz pcmoritz merged commit dd6eb71 into ray-project:master Oct 17, 2023
@pcmoritz pcmoritz deleted the remove-typing-extensions branch October 17, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants