[Train] Improve loggings for Train worker scheduling information#40536
Merged
matthewdeng merged 5 commits intoray-project:masterfrom Oct 25, 2023
Merged
[Train] Improve loggings for Train worker scheduling information#40536matthewdeng merged 5 commits intoray-project:masterfrom
matthewdeng merged 5 commits intoray-project:masterfrom
Conversation
matthewdeng
reviewed
Oct 23, 2023
Contributor
There was a problem hiding this comment.
@scottsun94 can you leave your thoughts? Originally we wanted to keep it succinct but found that it is not sufficient for users to debug certain issues.
Contributor
There was a problem hiding this comment.
LGTM. Since it only shows up once (unless there are location changes), it's fine to be a bit more verbose.
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Contributor
|
LGTM. Thanks! |
matthewdeng
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, the placement and ranking information of distributed process groups in the log is unclear. Users must manually print out the world ranking, local ranking, and node IP. This PR improves log messages with more placement information to improve observability and debuggability.
Previous:
Now:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.