Skip to content

[Core]Fix NullPointerException cause by raylet id is empty when get actor info in java worker#40560

Merged
SongGuyang merged 1 commit intoray-project:masterfrom
larrylian:fix_java_get_actor_info
Oct 24, 2023
Merged

[Core]Fix NullPointerException cause by raylet id is empty when get actor info in java worker#40560
SongGuyang merged 1 commit intoray-project:masterfrom
larrylian:fix_java_get_actor_info

Conversation

@larrylian
Copy link
Contributor

@larrylian larrylian commented Oct 23, 2023

Why are these changes needed?

Fix NullPointerException cause by raylet id is empty when get actor info in java worker.
Calling get actor info API before the Actor is successfully scheduled will result in a NullPointerException.
image

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@larrylian larrylian requested a review from SongGuyang October 23, 2023 07:09
…rker

Signed-off-by: LarryLian <554538252@qq.com>
@larrylian larrylian force-pushed the fix_java_get_actor_info branch from 70a4b76 to 42dd62c Compare October 23, 2023 07:10
@SongGuyang SongGuyang self-assigned this Oct 23, 2023
Copy link
Contributor

@SongGuyang SongGuyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SongGuyang SongGuyang merged commit 94beb5e into ray-project:master Oct 24, 2023
@rickyyx rickyyx mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants