Skip to content

[data] add AllToAllAPI to dataset methods#40842

Merged
c21 merged 10 commits intoray-project:masterfrom
Zandew:all-to-all-api
Nov 2, 2023
Merged

[data] add AllToAllAPI to dataset methods#40842
c21 merged 10 commits intoray-project:masterfrom
Zandew:all-to-all-api

Conversation

@Zandew
Copy link
Contributor

@Zandew Zandew commented Oct 31, 2023

Why are these changes needed?

Adds an AllToAllAPI decorator for Dataset methods that create all-to-all operators.
Screenshot 2023-10-31 at 5 50 46 PM

The list:

  • repartition
  • random_shuffle
  • randomize_block_order
  • groupby
  • unique
  • aggregate
  • sum
  • min
  • max
  • mean
  • std
  • sort

Please let me know if I missed any

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@Zandew Zandew changed the title all to all api [data] add AllToAllAPI to dataset methods Nov 1, 2023
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@Zandew Zandew marked this pull request as ready for review November 1, 2023 00:53
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Zandew and others added 3 commits November 1, 2023 11:31
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@c21 c21 merged commit 45ac625 into ray-project:master Nov 2, 2023
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
Adds an `AllToAllAPI` decorator for `Dataset` methods that create all-to-all operators.

The list:

- repartition
- random_shuffle
- randomize_block_order
- groupby
- unique
- aggregate
- sum
- min
- max
- mean
- std
- sort

Please let me know if I missed any

Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Co-authored-by: Cheng Su <scnju13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants