[Train] Add a barrier in RayTrainReportCallback to ensure synchronous reporting.#40875
Merged
matthewdeng merged 1 commit intoray-project:masterfrom Nov 3, 2023
Conversation
69756f4 to
ab71a07
Compare
matthewdeng
approved these changes
Nov 3, 2023
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
… reporting. (ray-project#40875) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
ray.train.reportensures that all workers enter at the same time, but there are no barriers preventing all workers from exiting at the same time. This could lead to anFileNotFoundErrorinRayTrainReportCallback, where local_rank_0 worker exit earlier, deleted the ckpt folder, while other workers are still uploading it.This PR fixed this bug by adding a barrier call right after
ray.train.report.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.