[RLlib] Remove utilities/tests/classes not needed anymore. by sven1977 · Pull Request #40939 · ray-project/ray

sven1977 · 2023-11-03T20:16:34Z

Remove utilities/tests/classes not needed anymore.

Why are these changes needed?

Related issue number

Checks

I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it in doc/source/tune/api/ under the
  corresponding .rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>

…ve_utilities_tests_classes_not_needed_anymore

Signed-off-by: sven1977 <svenmika1977@gmail.com>

…anymore

Signed-off-by: sven1977 <svenmika1977@gmail.com>

…ve_utilities_tests_classes_not_needed_anymore

…ot_needed_anymore' into remove_utilities_tests_classes_not_needed_anymore

Signed-off-by: sven1977 <svenmika1977@gmail.com>

…ve_utilities_tests_classes_not_needed_anymore

Signed-off-by: sven1977 <svenmika1977@gmail.com>

…ve_utilities_tests_classes_not_needed_anymore

Signed-off-by: sven1977 <svenmika1977@gmail.com>

…ve_utilities_tests_classes_not_needed_anymore

Signed-off-by: sven1977 <svenmika1977@gmail.com>

kouroshHakha · 2023-11-15T15:57:58Z

NOTE: premerge tests are failing.

kouroshHakha

It's just not clear to me what the decision process behind removals are. I have asked why on some of those that I would probably not have deleted. Some explanation on the process is missing on the PR details.

kouroshHakha · 2023-11-16T04:01:18Z

rllib/examples/custom_keras_model.py

why this one?

kouroshHakha · 2023-11-16T04:02:31Z

rllib/examples/custom_rnn_model.py

should we have an equivalent RLModule example for this?

Yes :) Undone

kouroshHakha · 2023-11-16T04:03:24Z

rllib/examples/custom_torch_policy.py

We should have a customer EnvRunner equivalent for this?

More like a custom Learner? The "custom" bit here is the loss function. Undone.

kouroshHakha · 2023-11-16T04:05:42Z

rllib/examples/multi-agent-leela-chess-zero.py

Has this been moved to the contrib folder?

Good catch. This is actually a "tuned_example". Created it in rllib_contrib. It wasn't run as a test in the old CI, but I activated it now. Let's see whether it learns a little bit (0.6 win rate vs random should be doable :) ).

kouroshHakha · 2023-11-16T04:08:11Z

rllib/examples/preprocessing_disabled.py

This is still an experimental API that we should no longer pursue. It's off by default and will be fully replaced by the new connectors.

kouroshHakha · 2023-11-16T04:09:17Z

rllib/examples/recommender_system_with_recsim_and_slateq.py

SlateQ is now in rllib_contrib.

kouroshHakha · 2023-11-16T04:09:42Z

rllib/examples/remote_base_env_with_custom_api.py

kouroshHakha · 2023-11-16T04:09:56Z

rllib/examples/remote_envs_with_inference_done_on_main_node.py

kouroshHakha · 2023-11-16T04:11:23Z

rllib/examples/vizdoom_with_attention_net.py

…ve_utilities_tests_classes_not_needed_anymore

Signed-off-by: sven1977 <svenmika1977@gmail.com>

sven1977 · 2023-11-16T17:48:44Z

Thanks for your review @kouroshHakha !
I admit some of the example removals are debateable. The main thought was that some of the more advanced features that we don't really want users to use anymore b/c they will very soon be on the new stack, we can take out already. However, I undid all those examples removals that you questioned.

And yes, we will replace most of our examples with new stack equivalents, but also clean up this folder well (it's become pretty messy over time :( ).

Signed-off-by: sven1977 <svenmika1977@gmail.com>

…anymore

…ve_utilities_tests_classes_not_needed_anymore

…ot_needed_anymore' into remove_utilities_tests_classes_not_needed_anymore

Signed-off-by: sven1977 <svenmika1977@gmail.com>

…ve_utilities_tests_classes_not_needed_anymore

…ct#40939)

sven1977 added 3 commits November 3, 2023 21:15

wip

b3af3f5

Signed-off-by: sven1977 <svenmika1977@gmail.com>

Merge branch 'master' of https://github.com/ray-project/ray into remo…

86b9116

…ve_utilities_tests_classes_not_needed_anymore

wip

cfa3297

Signed-off-by: sven1977 <svenmika1977@gmail.com>

sven1977 requested review from ArturNiederfahrenhorst, avnishn, kouroshHakha, maxpumperla and smorad as code owners November 3, 2023 20:16

sven1977 assigned kouroshHakha Nov 3, 2023

sven1977 added 15 commits November 3, 2023 21:28

wip

c995a1c

Signed-off-by: sven1977 <svenmika1977@gmail.com>

wip

fa1bdf2

Signed-off-by: sven1977 <svenmika1977@gmail.com>

wip

68c5880

Signed-off-by: sven1977 <svenmika1977@gmail.com>

Merge branch 'master' into remove_utilities_tests_classes_not_needed_…

1b3f0b4

…anymore

wip

ac7bed9

Signed-off-by: sven1977 <svenmika1977@gmail.com>

Merge branch 'master' of https://github.com/ray-project/ray into remo…

8eef998

…ve_utilities_tests_classes_not_needed_anymore

Merge remote-tracking branch 'origin/remove_utilities_tests_classes_n…

9fefd06

…ot_needed_anymore' into remove_utilities_tests_classes_not_needed_anymore

wip

3a0d50e

Signed-off-by: sven1977 <svenmika1977@gmail.com>

Merge branch 'master' of https://github.com/ray-project/ray into remo…

ef0d52c

…ve_utilities_tests_classes_not_needed_anymore

wip

d34d0ec

Signed-off-by: sven1977 <svenmika1977@gmail.com>

Merge branch 'master' of https://github.com/ray-project/ray into remo…

9b8b56c

…ve_utilities_tests_classes_not_needed_anymore

Merge branch 'master' of https://github.com/ray-project/ray into remo…

5ea7b18

…ve_utilities_tests_classes_not_needed_anymore

wip

a680b11

Signed-off-by: sven1977 <svenmika1977@gmail.com>

Merge branch 'master' of https://github.com/ray-project/ray into remo…

077edbf

…ve_utilities_tests_classes_not_needed_anymore

wip

dba8364

Signed-off-by: sven1977 <svenmika1977@gmail.com>

kouroshHakha reviewed Nov 16, 2023

View reviewed changes

sven1977 added 2 commits November 16, 2023 17:01

Merge branch 'master' of https://github.com/ray-project/ray into remo…

ec9e95c

…ve_utilities_tests_classes_not_needed_anymore

wip

28795c0

Signed-off-by: sven1977 <svenmika1977@gmail.com>

LINT

217d7de

Signed-off-by: sven1977 <svenmika1977@gmail.com>

sven1977 added 3 commits November 17, 2023 09:31

Merge branch 'master' into remove_utilities_tests_classes_not_needed_…

ad60a7d

…anymore

Merge branch 'master' of https://github.com/ray-project/ray into remo…

9d20eaf

…ve_utilities_tests_classes_not_needed_anymore

Merge remote-tracking branch 'origin/remove_utilities_tests_classes_n…

b042cd0

…ot_needed_anymore' into remove_utilities_tests_classes_not_needed_anymore

kouroshHakha approved these changes Nov 20, 2023

View reviewed changes

sven1977 added 2 commits November 20, 2023 17:58

wip

4b84861

Signed-off-by: sven1977 <svenmika1977@gmail.com>

Merge branch 'master' of https://github.com/ray-project/ray into remo…

f172da6

…ve_utilities_tests_classes_not_needed_anymore

sven1977 requested a review from a team as a code owner November 20, 2023 16:58

sven1977 merged commit af4c431 into ray-project:master Nov 20, 2023

ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023

[RLlib] Remove utilities/tests/classes not needed anymore. (ray-proje…

f040b54

…ct#40939)

simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Dec 17, 2025

[RLlib] Remove utilities/tests/classes not needed anymore. (ray-proje…

b634db6

…ct#40939)

Conversation

sven1977 commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are these changes needed?

Related issue number

Checks

Uh oh!

kouroshHakha commented Nov 15, 2023

Uh oh!

kouroshHakha left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sven1977 commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sven1977 commented Nov 3, 2023 •

edited

Loading