[Data] Fix BigQueryDatasource fault tolerance bugs#40986
Merged
bveeramani merged 15 commits intoray-project:masterfrom Nov 15, 2023
Merged
[Data] Fix BigQueryDatasource fault tolerance bugs#40986bveeramani merged 15 commits intoray-project:masterfrom
bveeramani merged 15 commits intoray-project:masterfrom
Conversation
Signed-off-by: Matthew Tang <tangmatthew@google.com>
matthew29tang
requested review from
Zandew,
amogkam,
bveeramani,
c21,
ericl,
raulchen,
scottjlee,
scv119 and
stephanie-wang
as code owners
bveeramani
reviewed
Nov 7, 2023
…atasource-write-fix
Signed-off-by: Matthew Tang <tangmatthew@google.com>
…atasource-write-fix
Signed-off-by: Matthew Tang <tangmatthew@google.com>
…atasource-write-fix
bveeramani
reviewed
Nov 14, 2023
Member
bveeramani
left a comment
bveeramani
left a comment
There was a problem hiding this comment.
Thanks for the fix! Pretty much LGTM.
Signed-off-by: Matthew Tang <tangmatthew@google.com>
Signed-off-by: Matthew Tang <tangmatthew@google.com>
…atasource-write-fix
bveeramani
approved these changes
Nov 14, 2023
Signed-off-by: Matthew Tang <tangmatthew@google.com>
…atasource-write-fix
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
This PR fixes a bug with fault tolerance that caused duplicate blocks to be written if a single block write fails. Also fixes a bug where the write silently succeeds if MAX_RETRY_CNT is reached. --------- Signed-off-by: Matthew Tang <tangmatthew@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes a bug with fault tolerance that caused duplicate blocks to be written if a single block write fails.
Also fixes a bug where the write silently succeeds if
MAX_RETRY_CNTis reached.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.