[data] Inherit block size from downstream ops#41019
Merged
stephanie-wang merged 27 commits intoray-project:masterfrom Nov 29, 2023
Merged
[data] Inherit block size from downstream ops#41019stephanie-wang merged 27 commits intoray-project:masterfrom
stephanie-wang merged 27 commits intoray-project:masterfrom
Conversation
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
…into data-metrics-testing
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
raulchen
reviewed
Nov 14, 2023
Contributor
raulchen
left a comment
raulchen
left a comment
There was a problem hiding this comment.
LGTM overall. Will take another look after the stacked PR gets merged.
python/ray/data/_internal/logical/rules/inherit_target_max_block_size.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/logical/rules/set_read_parallelism.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
stephanie-wang
requested review from
Zandew,
amogkam,
bveeramani,
c21,
ericl,
scottjlee and
scv119
as code owners
stephanie-wang
changed the title
raulchen
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Stacked on #40757
Compute the block size for each operation before applying other optimizer rules that depend on it (SplitReadOutputBlocksRule). This also simplifies the block sizing, so we always propagate an op's target block size to all upstream ops, until we find an op that has a different block size set.
Related issue number
Closes #41018.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.