[Data] Add retries to file writes#41263
Merged
bveeramani merged 6 commits intoray-project:masterfrom Nov 22, 2023
Merged
Conversation
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
Zandew,
amogkam,
c21,
ericl,
raulchen,
scottjlee,
scv119 and
stephanie-wang
as code owners
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
raulchen
approved these changes
Nov 21, 2023
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
If you're writing a large dataset to cloud storage like S3, you might run into transient errors. To prevent your entire job from failing, this PR adds retries for writes. Note that we previously performed retries for opening a file for writing, but didn't perform retries for the actual writes. --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If you're writing a large dataset to cloud storage like S3, you might run into transient errors. To prevent your entire job from failing, this PR adds retries for writes.
Note that we previously performed retries for opening a file for writing, but didn't perform retries for the actual writes.
Related issue number
Fixes #41211
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.