[Train] Remove Legacy Trainers' code#41276
Merged
matthewdeng merged 3 commits intoray-project:masterfrom Nov 22, 2023
Merged
Conversation
woshiyyya
requested review from
Zandew,
amogkam,
bveeramani,
c21,
ericl,
raulchen,
scottjlee,
scv119 and
stephanie-wang
as code owners
matthewdeng
approved these changes
Nov 21, 2023
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
woshiyyya
requested review from
a team,
Yard1,
justinvyu,
krfricke,
maxpumperla,
richardliaw and
xwjiang2010
as code owners
justinvyu
reviewed
Nov 22, 2023
Comment on lines
-74
to
-75
| data_loader.dataset.num_processes = 1 | ||
| data_loader.dataset.process_index = 0 |
bveeramani
approved these changes
Nov 22, 2023
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We deprecated
LightningTrainer,TransformersTrainer,AccelerateTrainerin Ray 2.8, and this PR is the followup work to remove the legacy code.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.