[data] Fix the issue that DataContext is not propagated when using streaming_split#41473
Merged
raulchen merged 2 commits intoray-project:masterfrom Nov 29, 2023
Merged
Conversation
…reaming_split Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
requested review from
Zandew,
amogkam,
bveeramani,
c21,
ericl,
scottjlee,
scv119 and
stephanie-wang
as code owners
matthewdeng
reviewed
Nov 29, 2023
Contributor
There was a problem hiding this comment.
@scottjlee do you know if this would remove the need for #40116?
Contributor
Author
There was a problem hiding this comment.
that PR should still be needed. It propagates DataContext from the driver to trainer workers. While this PR propagates DataContext from the trainer workers to the split coordinator actor.
c21
approved these changes
Nov 29, 2023
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This bug makes custom DataContext not take effect for training jobs.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.