[Data] Add example of how to read and write custom file types#41785
Merged
bveeramani merged 12 commits intoray-project:masterfrom Dec 12, 2023
Merged
[Data] Add example of how to read and write custom file types#41785bveeramani merged 12 commits intoray-project:masterfrom
bveeramani merged 12 commits intoray-project:masterfrom
Conversation
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
Zandew,
amogkam,
c21,
ericl,
raulchen,
scottjlee,
scv119 and
stephanie-wang
as code owners
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
stephanie-wang
requested changes
Dec 11, 2023
Contributor
stephanie-wang
left a comment
stephanie-wang
left a comment
There was a problem hiding this comment.
Where is the page that's being removed?
stephanie-wang
added
the
@author-action-required
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Member
Author
The old example was removed in early October https://github.com/ray-project/ray/pull/40127/files#diff-bdb1b1b7bd5ed18cb40f385021de9e23dfdb78061615a5490b3ca20fc82098f5. |
bveeramani
removed
the
@author-action-required
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
stephanie-wang
approved these changes
Dec 11, 2023
Contributor
stephanie-wang
left a comment
stephanie-wang
left a comment
There was a problem hiding this comment.
Looks good, but let's add the note about how to do write with map also.
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
added a commit
to bveeramani/ray
that referenced
this pull request
Dec 12, 2023
…oject#41785) ray-project#40127 removed the "Implementing a Custom Datasource" example because it used deprecated APIs. This PR introduces a new example that uses up-to-date APIs. --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#40127 removed the "Implementing a Custom Datasource" example because it used deprecated APIs. This PR introduces a new example that uses up-to-date APIs.
Related issue number
See also #40296
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.