[Data] Add read_json() fallback to json.load() when pyarrow read fails#42558
Merged
c21 merged 10 commits intoray-project:masterfrom Jan 23, 2024
Merged
[Data] Add read_json() fallback to json.load() when pyarrow read fails#42558c21 merged 10 commits intoray-project:masterfrom
read_json() fallback to json.load() when pyarrow read fails#42558c21 merged 10 commits intoray-project:masterfrom
Conversation
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
…into 0119-json-fallback
Signed-off-by: Scott Lee <sjl@anyscale.com>
scottjlee
requested review from
Zandew,
amogkam,
bveeramani,
c21,
ericl,
raulchen,
scv119 and
stephanie-wang
as code owners
added 2 commits
January 23, 2024 10:13
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
c21
approved these changes
Jan 23, 2024
khluu
pushed a commit
to khluu/ray
that referenced
this pull request
Jan 24, 2024
…fails (ray-project#42558) When `pyarrow.json` fails to read in a JSON file for whatever reason, we add a fallback to reading in the bytes of the file, then using `json.load()` to parse the JSON, so that we can better support JSON files. Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: khluu <khluu000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When
pyarrow.jsonfails to read in a JSON file for whatever reason, we add a fallback to reading in the bytes of the file, then usingjson.load()to parse the JSON, so that we can better support JSON files.Related issue number
Closes #42516
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.