[Data] Use application-level retries for Parquet metadata tasks#42922
Merged
bveeramani merged 10 commits intoray-project:masterfrom Feb 13, 2024
Merged
[Data] Use application-level retries for Parquet metadata tasks#42922bveeramani merged 10 commits intoray-project:masterfrom
bveeramani merged 10 commits intoray-project:masterfrom
Conversation
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
c21
reviewed
Feb 7, 2024
Contributor
c21
left a comment
There was a problem hiding this comment.
Thanks @bveeramani! Having some comments.
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
c21
approved these changes
Feb 12, 2024
Contributor
c21
left a comment
There was a problem hiding this comment.
LGTM pending the test for the user workload.
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#42044 updated the
ParquetDatasourcelogic so that Ray retries metadata fetching tasks that raiseOSErrors.ray/python/ray/data/datasource/parquet_datasource.py
Lines 295 to 298 in ba3cfa0
The problem is that we retry tasks indefinitely, so if a metadata fetching tasks raises a non-transient
OSError, your program freezes without warning.ray/python/ray/data/_internal/remote_fn.py
Line 26 in ba3cfa0
To fix this issue, this PR replaces the Ray Core-level retry with finite application-level retries. It also updates the retry logic to apply jitter to backoffs that exceed the limit.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.