Skip to content

[ray dashboard] Fix sorting order on cluster page#42929

Merged
rkooo567 merged 2 commits intoray-project:masterfrom
nikitavemuri:nikita/fix-cluster-node-sort-order
Feb 2, 2024
Merged

[ray dashboard] Fix sorting order on cluster page#42929
rkooo567 merged 2 commits intoray-project:masterfrom
nikitavemuri:nikita/fix-cluster-node-sort-order

Conversation

@nikitavemuri
Copy link
Contributor

@nikitavemuri nikitavemuri commented Feb 1, 2024

Why are these changes needed?

Sets the default sorting order of nodes on the clusters page to (1) alive nodes first then alphabetically for other states (2) head node before worker nodes (3) alphabetical by node ID.

Related issue number

Closes #42666

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Nikita Vemuri added 2 commits February 1, 2024 14:47
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@nikitavemuri nikitavemuri changed the title [WIP] [ray dashboard] Fix sorting order on cluster page [ray dashboard] Fix sorting order on cluster page Feb 1, 2024
@nikitavemuri nikitavemuri marked this pull request as ready for review February 1, 2024 22:59
@nikitavemuri nikitavemuri requested a review from alanwguo February 1, 2024 22:59
Copy link
Contributor

@alanwguo alanwguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh interesting. i didn't think dead head nodes was possible

@nikitavemuri nikitavemuri added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Feb 2, 2024
@rkooo567 rkooo567 merged commit c202890 into ray-project:master Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-ok The tagger certifies test failures are unrelated and assumes personal liability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dashboard] Dead head nodes shouldn't stay at the top.

3 participants