[ray dashboard] Fix sorting order on cluster page#42929
Merged
rkooo567 merged 2 commits intoray-project:masterfrom Feb 2, 2024
Merged
[ray dashboard] Fix sorting order on cluster page#42929rkooo567 merged 2 commits intoray-project:masterfrom
rkooo567 merged 2 commits intoray-project:masterfrom
Conversation
added 2 commits
February 1, 2024 14:47
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
alanwguo
approved these changes
Feb 1, 2024
Contributor
alanwguo
left a comment
There was a problem hiding this comment.
oh interesting. i didn't think dead head nodes was possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Sets the default sorting order of nodes on the clusters page to (1) alive nodes first then alphabetically for other states (2) head node before worker nodes (3) alphabetical by node ID.
Related issue number
Closes #42666
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.