Skip to content

[Data] Hard deprecate num_blocks parameter of random_shuffle#43341

Merged
bveeramani merged 1 commit intoray-project:masterfrom
bveeramani:num-blocks-random-shuffle
Feb 22, 2024
Merged

[Data] Hard deprecate num_blocks parameter of random_shuffle#43341
bveeramani merged 1 commit intoray-project:masterfrom
bveeramani:num-blocks-random-shuffle

Conversation

@bveeramani
Copy link
Member

Why are these changes needed?

We soft deprecated the num_blocks parameter of Dataset.random_shuffle in Ray 2.9 in favor of Dataset.repartition. This PR hard deprecates the parameter for Ray 2.10.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani merged commit 7c5e944 into ray-project:master Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants