[Data] Modify ImageDatasource to use Image.BILINEAR as the default image resampling filter.#43484
Merged
c21 merged 3 commits intoray-project:masterfrom Mar 5, 2024
Merged
Conversation
Signed-off-by: ronyw7 <yifengwang@berkeley.edu>
c21
approved these changes
Feb 28, 2024
bveeramani
approved these changes
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ray Data's current
ImageDatasourceuses PIL'sresizefunction as the image processing backend, which by default uses theImage.BICUBICresampling filter. In practice, we found this is around 20% slower than using theImage.BILINEARfilter, which is the default option in torch vision.Here are some benchmark results:
This is a unit test where we load one single image and resize it, repeated 10000 times. Note the time difference between the current (Image.BICUBIC) filter vs. proposed (Image.BILINEAR).
This is an end-to-end benchmark modified from @stephanie-wang 's image loader microbenchmark. Here, we demonstrate the actual effect on the ray data image loading pipeline. Using the
BILINEARfilter as default leads to a ~22% increase in throughput.If a user still wishes to use the
BICUBICfilter, this is still easily achievable by applying a UDFresize_fnafter the images have been read. For instance, we can choosecv2's INTER_CUBIC or PIL's original resize (this requires the use of PIL'sfromarraythough, as the output ofread_imageare numpy arrays; this conversion lowers throughput).Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.