[data][train] Update "Data Loading and Preprocessing" doc#44165
Merged
raulchen merged 24 commits intoray-project:masterfrom Mar 26, 2024
Merged
[data][train] Update "Data Loading and Preprocessing" doc#44165raulchen merged 24 commits intoray-project:masterfrom
raulchen merged 24 commits intoray-project:masterfrom
Conversation
Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
requested review from
a team,
justinvyu,
matthewdeng and
woshiyyya
as code owners
Signed-off-by: Hao Chen <chenh1024@gmail.com>
scottjlee
approved these changes
Mar 20, 2024
Contributor
scottjlee
left a comment
scottjlee
left a comment
There was a problem hiding this comment.
pending fixing docs/premerge failures
angelinalg
approved these changes
Mar 20, 2024
Contributor
angelinalg
left a comment
angelinalg
left a comment
There was a problem hiding this comment.
Please correct any subjects that I added to convert passive voice sentences to active voice.
Also, consider using Vale to catch spelling and style errors. (go/vale)
| @@ -71,6 +72,9 @@ Data ingestion can be set up with four basic steps: | |||
| # Step 4: Access the dataset shard for the training worker via | |||
Contributor
There was a problem hiding this comment.
The indentation and step order looks wrong. This should be step 3?
Contributor
Author
There was a problem hiding this comment.
from runtime's perspective, this happens after the step 3 below
Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
requested review from
amogkam,
bveeramani,
c21,
ericl,
omatthew98,
scv119 and
stephanie-wang
as code owners
raulchen
added a commit
to raulchen/ray
that referenced
this pull request
Mar 27, 2024
…t#44165) --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Hao Chen <chenh1024@gmail.com>
8 tasks
stephanie-wang
pushed a commit
to stephanie-wang/ray
that referenced
this pull request
Mar 27, 2024
…t#44165) --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Co-authored-by: Scott Lee <scottjlee@users.noreply.github.com> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.