[RLlib] User warnings and guidance in synchronous_parallel_sample.#44340
Merged
sven1977 merged 1 commit intoray-project:masterfrom Apr 2, 2024
Merged
Conversation
…nce if no sample data could be collected. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
synchronous_parallel_samplesynchronous_parallel_sample.
sven1977
approved these changes
Apr 2, 2024
Contributor
sven1977
left a comment
There was a problem hiding this comment.
LGTM. Thanks for these fixes @simonsays1980 !
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When sampling from remote workers the new
synchronous_parallel_samplelogic added thesample_timeout_sto the remote workers call. This can lead to errors in theLearner.update_from_batch(and related methods) as the list of episodes is empty. To decrease debugging efforts we give some warnings instead that should also guide the user to related parameters that could be tuned to avoid the errors.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.