Skip to content

[RLlib] User warnings and guidance in synchronous_parallel_sample.#44340

Merged
sven1977 merged 1 commit intoray-project:masterfrom
simonsays1980:add-warning-to-sample-timeout
Apr 2, 2024
Merged

[RLlib] User warnings and guidance in synchronous_parallel_sample.#44340
sven1977 merged 1 commit intoray-project:masterfrom
simonsays1980:add-warning-to-sample-timeout

Conversation

@simonsays1980
Copy link
Contributor

@simonsays1980 simonsays1980 commented Mar 28, 2024

Why are these changes needed?

When sampling from remote workers the new synchronous_parallel_sample logic added the sample_timeout_s to the remote workers call. This can lead to errors in the Learner.update_from_batch (and related methods) as the list of episodes is empty. To decrease debugging efforts we give some warnings instead that should also guide the user to related parameters that could be tuned to avoid the errors.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…nce if no sample data could be collected.

Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
@simonsays1980 simonsays1980 self-assigned this Mar 28, 2024
@sven1977 sven1977 changed the title User warnings and guidance in synchronous_parallel_sample [RLlib] User warnings and guidance in synchronous_parallel_sample. Apr 2, 2024
@sven1977 sven1977 marked this pull request as ready for review April 2, 2024 06:59
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for these fixes @simonsays1980 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants