Skip to content

[RLlib] Fix IMPALA/APPO old API stack queueing stats.#44446

Merged
sven1977 merged 2 commits intoray-project:masterfrom
sven1977:fix_impala_appo_memory_leak
Apr 4, 2024
Merged

[RLlib] Fix IMPALA/APPO old API stack queueing stats.#44446
sven1977 merged 2 commits intoray-project:masterfrom
sven1977:fix_impala_appo_memory_leak

Conversation

@sven1977
Copy link
Contributor

@sven1977 sven1977 commented Apr 3, 2024 •
edited
Loading

Fix IMPALA/APPO old API stack queueing stats.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
6aa57a0 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 changed the title [RLlib] Fix broken RLlib examples folder links (introduced by prior examples scripts PR). [RLlib] Fix IMPALA/APPO old API stack queueing stats. Apr 3, 2024
simonsays1980
simonsays1980 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977
wip
0de7242 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 added rllib RLlib related issues rllib-oldstack-cleanup labels Apr 3, 2024
@sven1977 sven1977 merged commit 81ae980 into ray-project:master Apr 4, 2024
@sven1977 sven1977 deleted the fix_impala_appo_memory_leak branch October 10, 2024 13:36
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Dec 17, 2025
@sven1977
[RLlib] Fix IMPALA/APPO old API stack queueing stats. (ray-project#44446
2b35e44 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

Assignees

@simonsays1980 simonsays1980

Labels

rllib RLlib related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sven1977 @simonsays1980 @angelinalg