Skip to content

[Data] Store Ray Data logs in special subdirectory#44743

Merged
bveeramani merged 5 commits intoray-project:masterfrom
bveeramani:add-subdirectory
Apr 15, 2024
Merged

[Data] Store Ray Data logs in special subdirectory#44743
bveeramani merged 5 commits intoray-project:masterfrom
bveeramani:add-subdirectory

Conversation

@bveeramani
Copy link
Member

Why are these changes needed?

Currently, Ray Data stores logs in the {session_directory}/logs directory along with all other Ray logs. This PR changes the behavior so Ray Data stores log in a dedicated {session_directory}/logs/ray-data directory.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Copy link
Member Author

cc @brycehuang30

Copy link
Contributor

@scottjlee scottjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also update ray data documentation accordingly with the new subdirectory? thanks!

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update all examples documentation with:

Starting execution of Dataset. Full log is in .../logs/ray-data.log

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani merged commit bb58e5c into ray-project:master Apr 15, 2024
@bveeramani bveeramani deleted the add-subdirectory branch April 15, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants