Skip to content

[Train] Enable debug logging; fix default actor_locality_enabled#56632

Merged
justinvyu merged 3 commits intomasterfrom
srinathk10/train-tests-debug
Sep 18, 2025
Merged

[Train] Enable debug logging; fix default actor_locality_enabled#56632
justinvyu merged 3 commits intomasterfrom
srinathk10/train-tests-debug

Conversation

@srinathk10
Copy link
Contributor

@srinathk10 srinathk10 commented Sep 17, 2025

Why are these changes needed?

[Train] Enable debug logging in Release tests

  • Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager.
  • Enable Ray Data progress bar.
  • Set actor_locality_enabled to True

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables debug logging and progress bars for release tests. Specifically, it sets the RAY_DATA_DEBUG_RESOURCE_MANAGER environment variable for the training_ingest_benchmark-task=image_classification test to get more verbose stats from the resource manager. It also changes the default value of enable_operator_progress_bars to True in the RayDataConfig for benchmarks, which will enable Ray Data progress bars for tests using this configuration. The changes are straightforward and correctly implement the intended debugging enhancements. I have no further suggestions.

@ray-gardener ray-gardener bot added train Ray Train Related Issue release-test release test labels Sep 17, 2025
@srinathk10 srinathk10 added the go add ONLY when ready to merge, run all tests label Sep 17, 2025
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
@srinathk10 srinathk10 changed the title [Train] Enable debug logging in Release tests [Train] Enable debug logging; Fix defaults in Release tests Sep 18, 2025
@srinathk10 srinathk10 changed the title [Train] Enable debug logging; Fix defaults in Release tests [Train] Enable debug logging Sep 18, 2025
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
@srinathk10 srinathk10 changed the title [Train] Enable debug logging [Train] Enable debug logging; fix default actor_locality_enabled Sep 18, 2025
@justinvyu justinvyu enabled auto-merge (squash) September 18, 2025 20:13
@justinvyu justinvyu merged commit ad91d2e into master Sep 18, 2025
5 of 6 checks passed
@justinvyu justinvyu deleted the srinathk10/train-tests-debug branch September 18, 2025 20:49
zma2 pushed a commit to zma2/ray that referenced this pull request Sep 23, 2025
…-project#56632)

- Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager.
- Enable Ray Data progress bar.
- Set actor_locality_enabled to True

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
Signed-off-by: Zhiqiang Ma <zhiqiang.ma@intel.com>
ZacAttack pushed a commit to ZacAttack/ray that referenced this pull request Sep 24, 2025
…-project#56632)

- Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager.
- Enable Ray Data progress bar.
- Set actor_locality_enabled to True

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
Signed-off-by: zac <zac@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Sep 24, 2025
)

- Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager.
- Enable Ray Data progress bar.
- Set actor_locality_enabled to True

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
marcostephan pushed a commit to marcostephan/ray that referenced this pull request Sep 24, 2025
…-project#56632)

- Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager.
- Enable Ray Data progress bar.
- Set actor_locality_enabled to True

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
Signed-off-by: Marco Stephan <marco@magic.dev>
elliot-barn pushed a commit that referenced this pull request Sep 27, 2025
)

- Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager.
- Enable Ray Data progress bar.
- Set actor_locality_enabled to True

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
dstrodtman pushed a commit that referenced this pull request Oct 6, 2025
)

- Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager.
- Enable Ray Data progress bar.
- Set actor_locality_enabled to True

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
justinyeh1995 pushed a commit to justinyeh1995/ray that referenced this pull request Oct 20, 2025
…-project#56632)

- Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager.
- Enable Ray Data progress bar.
- Set actor_locality_enabled to True

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
…-project#56632)

- Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager.
- Enable Ray Data progress bar.
- Set actor_locality_enabled to True

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
…-project#56632)

- Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager.
- Enable Ray Data progress bar.
- Set actor_locality_enabled to True

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests release-test release test train Ray Train Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants