[Train] Enable debug logging; fix default actor_locality_enabled#56632
Merged
[Train] Enable debug logging; fix default actor_locality_enabled#56632
Conversation
Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables debug logging and progress bars for release tests. Specifically, it sets the RAY_DATA_DEBUG_RESOURCE_MANAGER environment variable for the training_ingest_benchmark-task=image_classification test to get more verbose stats from the resource manager. It also changes the default value of enable_operator_progress_bars to True in the RayDataConfig for benchmarks, which will enable Ray Data progress bars for tests using this configuration. The changes are straightforward and correctly implement the intended debugging enhancements. I have no further suggestions.
xinyuangui2
approved these changes
Sep 17, 2025
justinvyu
approved these changes
Sep 18, 2025
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
zma2
pushed a commit
to zma2/ray
that referenced
this pull request
Sep 23, 2025
…-project#56632) - Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager. - Enable Ray Data progress bar. - Set actor_locality_enabled to True --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com> Signed-off-by: Zhiqiang Ma <zhiqiang.ma@intel.com>
ZacAttack
pushed a commit
to ZacAttack/ray
that referenced
this pull request
Sep 24, 2025
…-project#56632) - Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager. - Enable Ray Data progress bar. - Set actor_locality_enabled to True --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com> Signed-off-by: zac <zac@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Sep 24, 2025
) - Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager. - Enable Ray Data progress bar. - Set actor_locality_enabled to True --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
marcostephan
pushed a commit
to marcostephan/ray
that referenced
this pull request
Sep 24, 2025
…-project#56632) - Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager. - Enable Ray Data progress bar. - Set actor_locality_enabled to True --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com> Signed-off-by: Marco Stephan <marco@magic.dev>
elliot-barn
pushed a commit
that referenced
this pull request
Sep 27, 2025
) - Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager. - Enable Ray Data progress bar. - Set actor_locality_enabled to True --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
) - Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager. - Enable Ray Data progress bar. - Set actor_locality_enabled to True --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
…-project#56632) - Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager. - Enable Ray Data progress bar. - Set actor_locality_enabled to True --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…-project#56632) - Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager. - Enable Ray Data progress bar. - Set actor_locality_enabled to True --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…-project#56632) - Enable RAY_DATA_DEBUG_RESOURCE_MANAGER for debugging resource manager. - Enable Ray Data progress bar. - Set actor_locality_enabled to True --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: Srinath Krishnamachari <68668616+srinathk10@users.noreply.github.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
[Train] Enable debug logging in Release tests
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.