[train][release] Attach a quick checkpoint when reporting metrics#56718
Merged
justinvyu merged 8 commits intoray-project:masterfrom Sep 24, 2025
Merged
[train][release] Attach a quick checkpoint when reporting metrics#56718justinvyu merged 8 commits intoray-project:masterfrom
justinvyu merged 8 commits intoray-project:masterfrom
Conversation
Signed-off-by: Lehui Liu <lehui@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the torch benchmark to be compatible with Ray Train V2 by attaching a checkpoint when reporting metrics. However, the current implementation has a critical issue where train.report() is only called by the rank 0 worker. In a distributed setting, all workers must call train.report(), otherwise the job will likely hang. I've provided a suggestion to fix this by moving the train.report() call out of the rank-check conditional block, ensuring all workers participate in reporting.
Signed-off-by: Lehui Liu <lehui@anyscale.com>
Signed-off-by: Lehui Liu <lehui@anyscale.com>
Signed-off-by: Lehui Liu <lehui@anyscale.com>
Signed-off-by: Lehui Liu <lehui@anyscale.com>
Signed-off-by: Lehui Liu <lehui@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Sep 27, 2025
…6718) In Train V2, Free-floating metrics without corresponding checkpoint are no longer automatically saved, so attach a checkpoint to metrics, so that we can emit some release test metrics such as the local time taken by each train worker. --------- Signed-off-by: Lehui Liu <lehui@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
…6718) In Train V2, Free-floating metrics without corresponding checkpoint are no longer automatically saved, so attach a checkpoint to metrics, so that we can emit some release test metrics such as the local time taken by each train worker. --------- Signed-off-by: Lehui Liu <lehui@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
…y-project#56718) In Train V2, Free-floating metrics without corresponding checkpoint are no longer automatically saved, so attach a checkpoint to metrics, so that we can emit some release test metrics such as the local time taken by each train worker. --------- Signed-off-by: Lehui Liu <lehui@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…y-project#56718) In Train V2, Free-floating metrics without corresponding checkpoint are no longer automatically saved, so attach a checkpoint to metrics, so that we can emit some release test metrics such as the local time taken by each train worker. --------- Signed-off-by: Lehui Liu <lehui@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…y-project#56718) In Train V2, Free-floating metrics without corresponding checkpoint are no longer automatically saved, so attach a checkpoint to metrics, so that we can emit some release test metrics such as the local time taken by each train worker. --------- Signed-off-by: Lehui Liu <lehui@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAY_TRAIN_V2_ENABLED=1.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.