[tune] Enable Train v2 in doc examples#56820
Merged
justinvyu merged 11 commits intoray-project:masterfrom Sep 24, 2025
Merged
Conversation
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request focuses on updating documentation examples to enable and use the new Ray Tune v2 API. The changes include migrating from older APIs like session.report to tune.report, updating checkpointing logic, and refactoring examples to use tune.Tuner instead of older patterns. Overall, the changes are consistent and align with the goal of adopting the v2 API. However, I've found one critical issue where a test is being enabled for a notebook file that is being deleted in this same PR, which will break the build.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
justinvyu
changed the title
matthewdeng
approved these changes
Sep 23, 2025
doc/source/tune/examples/BUILD.bazel
Outdated
| exclude = [ | ||
| "pbt_ppo_example.ipynb", | ||
| "tune-xgboost.ipynb", | ||
| "lightgbm_example.ipynb", # TODO: Uncomment after fixing Tune lightgbm callback. |
Contributor
There was a problem hiding this comment.
Can you make sure this is tracked somewhere?
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Can you include in PR description why we're removing Horovod here? Tune should still work directly with Horovod right? Is this just general cleanup since Horovod doesn't support py312?
Contributor
Author
There was a problem hiding this comment.
this uses horovod trainer which we don't have anymore
| " }\n", | ||
| "\n", | ||
| " checkpoint = train.get_checkpoint()\n", | ||
| " checkpoint = tune.get_checkpoint()\n", |
There was a problem hiding this comment.
Bug: Missing Import Causes Checkpoint Loading Failure
The tune.get_checkpoint() call was introduced without a visible import for the tune module. This likely causes a NameError, preventing the notebook from loading checkpoints and resuming training.
marcostephan
pushed a commit
to marcostephan/ray
that referenced
this pull request
Sep 24, 2025
Flip the flag for Tune doctest CI in preparation for turning on Train V2 by default. This doesn't have any behavior change, but this asserts that ray.train -> ray.tune updates have all happened. Note that a few tests have been left behind due to Tune lightgbm and Keras callbacks not being updated yet. We need to do the equivalent of this PR: ray-project#54787 * `lightgbm_example` * `lightgbm_example_cv` * `tune_mnist_keras` Deletes `horovod_simple.ipynb` example because we don't support `HorovodTrainer` anymore. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Marco Stephan <marco@magic.dev>
elliot-barn
pushed a commit
that referenced
this pull request
Sep 27, 2025
Flip the flag for Tune doctest CI in preparation for turning on Train V2 by default. This doesn't have any behavior change, but this asserts that ray.train -> ray.tune updates have all happened. Note that a few tests have been left behind due to Tune lightgbm and Keras callbacks not being updated yet. We need to do the equivalent of this PR: #54787 * `lightgbm_example` * `lightgbm_example_cv` * `tune_mnist_keras` Deletes `horovod_simple.ipynb` example because we don't support `HorovodTrainer` anymore. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
dstrodtman
pushed a commit
to dstrodtman/ray
that referenced
this pull request
Oct 6, 2025
Flip the flag for Tune doctest CI in preparation for turning on Train V2 by default. This doesn't have any behavior change, but this asserts that ray.train -> ray.tune updates have all happened. Note that a few tests have been left behind due to Tune lightgbm and Keras callbacks not being updated yet. We need to do the equivalent of this PR: ray-project#54787 * `lightgbm_example` * `lightgbm_example_cv` * `tune_mnist_keras` Deletes `horovod_simple.ipynb` example because we don't support `HorovodTrainer` anymore. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
7 tasks
justinvyu
added a commit
that referenced
this pull request
Oct 16, 2025
Ports over the remaining unit tests that were marked as TODOs from this series of PRs: #57534, #57256, #56868, #56820, #56816. Notably: * `test_new_dataset_config -> test_data_integration` * `test_backend -> test_torch_trainer, test_worker_group` * `test_gpu -> test_torch_gpu` This PR also finishes migrating the Tune LightGBM/Keras examples which were unblocked by #57042 and #57121. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
Flip the flag for Tune doctest CI in preparation for turning on Train V2 by default. This doesn't have any behavior change, but this asserts that ray.train -> ray.tune updates have all happened. Note that a few tests have been left behind due to Tune lightgbm and Keras callbacks not being updated yet. We need to do the equivalent of this PR: ray-project#54787 * `lightgbm_example` * `lightgbm_example_cv` * `tune_mnist_keras` Deletes `horovod_simple.ipynb` example because we don't support `HorovodTrainer` anymore. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
Ports over the remaining unit tests that were marked as TODOs from this series of PRs: ray-project#57534, ray-project#57256, ray-project#56868, ray-project#56820, ray-project#56816. Notably: * `test_new_dataset_config -> test_data_integration` * `test_backend -> test_torch_trainer, test_worker_group` * `test_gpu -> test_torch_gpu` This PR also finishes migrating the Tune LightGBM/Keras examples which were unblocked by ray-project#57042 and ray-project#57121. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
Ports over the remaining unit tests that were marked as TODOs from this series of PRs: ray-project#57534, ray-project#57256, ray-project#56868, ray-project#56820, ray-project#56816. Notably: * `test_new_dataset_config -> test_data_integration` * `test_backend -> test_torch_trainer, test_worker_group` * `test_gpu -> test_torch_gpu` This PR also finishes migrating the Tune LightGBM/Keras examples which were unblocked by ray-project#57042 and ray-project#57121. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
Ports over the remaining unit tests that were marked as TODOs from this series of PRs: #57534, #57256, #56868, #56820, #56816. Notably: * `test_new_dataset_config -> test_data_integration` * `test_backend -> test_torch_trainer, test_worker_group` * `test_gpu -> test_torch_gpu` This PR also finishes migrating the Tune LightGBM/Keras examples which were unblocked by #57042 and #57121. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
Flip the flag for Tune doctest CI in preparation for turning on Train V2 by default. This doesn't have any behavior change, but this asserts that ray.train -> ray.tune updates have all happened. Note that a few tests have been left behind due to Tune lightgbm and Keras callbacks not being updated yet. We need to do the equivalent of this PR: ray-project#54787 * `lightgbm_example` * `lightgbm_example_cv` * `tune_mnist_keras` Deletes `horovod_simple.ipynb` example because we don't support `HorovodTrainer` anymore. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
Ports over the remaining unit tests that were marked as TODOs from this series of PRs: ray-project#57534, ray-project#57256, ray-project#56868, ray-project#56820, ray-project#56816. Notably: * `test_new_dataset_config -> test_data_integration` * `test_backend -> test_torch_trainer, test_worker_group` * `test_gpu -> test_torch_gpu` This PR also finishes migrating the Tune LightGBM/Keras examples which were unblocked by ray-project#57042 and ray-project#57121. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
Ports over the remaining unit tests that were marked as TODOs from this series of PRs: ray-project#57534, ray-project#57256, ray-project#56868, ray-project#56820, ray-project#56816. Notably: * `test_new_dataset_config -> test_data_integration` * `test_backend -> test_torch_trainer, test_worker_group` * `test_gpu -> test_torch_gpu` This PR also finishes migrating the Tune LightGBM/Keras examples which were unblocked by ray-project#57042 and ray-project#57121. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
Flip the flag for Tune doctest CI in preparation for turning on Train V2 by default. This doesn't have any behavior change, but this asserts that ray.train -> ray.tune updates have all happened. Note that a few tests have been left behind due to Tune lightgbm and Keras callbacks not being updated yet. We need to do the equivalent of this PR: ray-project#54787 * `lightgbm_example` * `lightgbm_example_cv` * `tune_mnist_keras` Deletes `horovod_simple.ipynb` example because we don't support `HorovodTrainer` anymore. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
Ports over the remaining unit tests that were marked as TODOs from this series of PRs: ray-project#57534, ray-project#57256, ray-project#56868, ray-project#56820, ray-project#56816. Notably: * `test_new_dataset_config -> test_data_integration` * `test_backend -> test_torch_trainer, test_worker_group` * `test_gpu -> test_torch_gpu` This PR also finishes migrating the Tune LightGBM/Keras examples which were unblocked by ray-project#57042 and ray-project#57121. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flip the flag for Tune doctest CI in preparation for turning on Train V2 by default. This doesn't have any behavior change, but this asserts that ray.train -> ray.tune updates have all happened.
Note that a few tests have been left behind due to Tune lightgbm and Keras callbacks not being updated yet. We need to do the equivalent of this PR: #54787
lightgbm_examplelightgbm_example_cvtune_mnist_kerasDeletes
horovod_simple.ipynbexample because we don't supportHorovodTraineranymore.