[Data] - Download expr - cast to arrow before checking column#57146
Merged
richardliaw merged 2 commits intoray-project:masterfrom Oct 3, 2025
Merged
Conversation
Signed-off-by: Goutam V. <goutam@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the download expression logic where an AttributeError would occur if the input block was not a PyArrow Table. The change moves the block-to-Arrow conversion to before the column name check, ensuring that the .column_names attribute is always available. The fix is correct and improves the robustness of the download functionality. I've added a suggestion to include a unit test that specifically covers the fixed scenario with non-Arrow blocks to prevent future regressions.
aslonnie
reviewed
Oct 2, 2025
| return file_sizes | ||
|
|
||
| def __call__(self, block: pa.Table) -> Iterator[pa.Table]: | ||
| if not isinstance(block, pa.Table): |
Collaborator
There was a problem hiding this comment.
is it possible to have a unit test that can catch this?
Contributor
Author
There was a problem hiding this comment.
added UT
goutamvenkat-anyscale
added
data
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
…oject#57146) Signed-off-by: Seiji Eicher <seiji@anyscale.com>
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
liulehui
pushed a commit
to liulehui/ray
that referenced
this pull request
Oct 9, 2025
joshkodi
pushed a commit
to joshkodi/ray
that referenced
this pull request
Oct 13, 2025
…oject#57146) Signed-off-by: Josh Kodi <joshkodi@gmail.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…oject#57146) Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…oject#57146) Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Call
to_arrow()before invoking.column_namesRelated issue number
Checks
git commit -s) in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.