remove expensive debug logs from controller#57813
Merged
abrarsheikh merged 3 commits intomasterfrom Oct 17, 2025
Merged
Conversation
Signed-off-by: abrar <abrar@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes two expensive debug log statements from the autoscaling metric collection path in the controller, which should improve performance. The changes are correct and also clean up an unused import. My review suggests that while removing the logs is a good step, the information they contained (running and queued requests) is valuable for observability. I've recommended exposing these values as metrics instead, which would provide better visibility for monitoring and debugging without the performance cost of logging in a hot path.
ray-gardener
bot
added
serve
Signed-off-by: abrar <abrar@anyscale.com>
arcyleung
approved these changes
Oct 17, 2025
akyang-anyscale
approved these changes
Oct 17, 2025
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
logs in controller can be expensive for large cluster logs in autoscaling state and just noisy --------- Signed-off-by: abrar <abrar@anyscale.com>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
logs in controller can be expensive for large cluster logs in autoscaling state and just noisy --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
logs in controller can be expensive for large cluster logs in autoscaling state and just noisy --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
logs in controller can be expensive for large cluster logs in autoscaling state and just noisy --------- Signed-off-by: abrar <abrar@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
logs in controller can be expensive for large cluster logs in autoscaling state and just noisy --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
logs in controller can be expensive for large cluster logs in autoscaling state and just noisy --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logs in controller can be expensive for large cluster
logs in autoscaling state and just noisy