-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Data] Create unit test directory for fast, isolated tests #58445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Unit Tests | ||
|
|
||
| This directory contains unit tests that do not depend on distributed infrastructure or external dependencies. | ||
|
|
||
| ## Requirements | ||
|
|
||
| Unit tests in this directory must be: | ||
| - **Fast**: Execute in milliseconds, not seconds | ||
| - **Isolated**: No dependencies on Ray runtime, external services, or file I/O | ||
| - **Deterministic**: No randomness or time-based behavior | ||
|
|
||
| ## Restrictions | ||
|
|
||
| Tests should NOT: | ||
| - Initialize or use the Ray distributed runtime | ||
| - Use `time.sleep()` or other time-based delays | ||
| - Depend on external services, databases, or file systems | ||
| - Make network calls | ||
|
|
||
| ## Enforcement | ||
|
|
||
| The `conftest.py` in this directory enforces these restrictions by preventing: | ||
| - `ray.init()` from being called | ||
| - `time.sleep()` from being used | ||
|
|
||
| If a test requires any of these, it should be moved to the main test directory instead. |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import time | ||
|
|
||
| import pytest | ||
|
|
||
| import ray | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def disallow_ray_init(monkeypatch): | ||
| def raise_on_init(): | ||
| raise RuntimeError("Unit tests should not depend on Ray being initialized.") | ||
bveeramani marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| monkeypatch.setattr(ray, "init", raise_on_init) | ||
bveeramani marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def disallow_time_sleep(monkeypatch): | ||
| def raise_on_sleep(seconds): | ||
| raise RuntimeError( | ||
| f"Unit tests should not use time.sleep({seconds}). " | ||
| "Unit tests should be fast and deterministic." | ||
| ) | ||
|
|
||
| monkeypatch.setattr(time, "sleep", raise_on_sleep) | ||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.