[Data] Compute Expressions-fixed size array#58741
Merged
bveeramani merged 28 commits intoray-project:masterfrom Jan 14, 2026
Merged
[Data] Compute Expressions-fixed size array#58741bveeramani merged 28 commits intoray-project:masterfrom
bveeramani merged 28 commits intoray-project:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new _ArrayNamespace to handle fixed-size array operations in Ray Data expressions, adding flatten() and to_list() methods. The implementation is a good start, but I've identified a couple of issues in the new arr_namespace.py file. Specifically, the flatten() method has incorrect fallback logic that makes its behavior inconsistent, and the to_list() method can be optimized for better performance. My review includes suggestions to fix these issues for improved correctness and efficiency.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
400Ping
force-pushed
the
data/compute-expressions-arr
branch
from
a86b794 to
000cf1e
Compare
400Ping
changed the title
400Ping
changed the title
ray-gardener
bot
added
data
Contributor
|
Hi @400Ping Thanks for contribution. Can you fix the CI (lint issue)? |
Contributor
iamjustinhsu
left a comment
iamjustinhsu
left a comment
There was a problem hiding this comment.
Thanks @400Ping! Can you also add some tests?
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
400Ping
force-pushed
the
data/compute-expressions-arr
branch
from
987ca07 to
7819f4b
Compare
Signed-off-by: 400Ping <fourhundredping@gmail.com>
400Ping
changed the title
Contributor
Author
|
cc @goutamvenkat-anyscale PTAL |
Signed-off-by: Ping <fourhundredping@gmail.com>
Contributor
Author
|
@goutamvenkat-anyscale fixed, PTAL. |
Contributor
Author
Contributor
Author
|
cc @owenowenisme @bveeramani PTAL |
Contributor
Author
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Contributor
Author
Contributor
Author
Member
|
@400Ping Could you fix the conflict first? Thanks. |
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Contributor
Author
Done |
goutamvenkat-anyscale
requested changes
Jan 13, 2026
Contributor
goutamvenkat-anyscale
left a comment
goutamvenkat-anyscale
left a comment
There was a problem hiding this comment.
Overall looks good. Thanks.
Just a couple of comments
jeffery4011
pushed a commit
to jeffery4011/ray
that referenced
this pull request
Jan 20, 2026
## Description Completing the fixed-size array namespace operations ## Related issues Related to ray-project#58674 ## Additional information --------- Signed-off-by: 400Ping <fourhundredping@gmail.com> Signed-off-by: Ping <fourhundredping@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: jeffery4011 <jefferyshen1015@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
## Description Completing the fixed-size array namespace operations ## Related issues Related to ray-project#58674 ## Additional information --------- Signed-off-by: 400Ping <fourhundredping@gmail.com> Signed-off-by: Ping <fourhundredping@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
## Description Completing the fixed-size array namespace operations ## Related issues Related to ray-project#58674 ## Additional information --------- Signed-off-by: 400Ping <fourhundredping@gmail.com> Signed-off-by: Ping <fourhundredping@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
## Description Completing the fixed-size array namespace operations ## Related issues Related to ray-project#58674 ## Additional information --------- Signed-off-by: 400Ping <fourhundredping@gmail.com> Signed-off-by: Ping <fourhundredping@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completing the fixed-size array namespace operations
Related issues
Related to #58674
Additional information