[Data][Docs] Add read kafka user guide#58881
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a user guide for reading data from Kafka, which is a valuable addition to the documentation. The examples provided are clear and cover the main use cases. Additionally, the change to remove KafkaAuthConfig from the top-level ray.data namespace is a good step towards improving namespace hygiene, and the documentation correctly reflects the new import path from ray.data.read_api. I've included one suggestion to improve the clarity of the code examples in the new documentation.
owenowenisme
force-pushed
the
data/add-read-kafka-docs
branch
from
14bc635 to
43bb71f
Compare
owenowenisme
added
go
bveeramani
left a comment
bveeramani
left a comment
There was a problem hiding this comment.
Overall LGTM. Just one question about the KafkaAuthConfig
| from ray.data.iterator import DataIterator, DatasetIterator | ||
| from ray.data.preprocessor import Preprocessor | ||
| from ray.data.read_api import ( # noqa: F401 | ||
| KafkaAuthConfig, |
There was a problem hiding this comment.
What's the motivation for removing these?
I don't think we require importing from ray.data.read_api anywhere else
There was a problem hiding this comment.
Added back, I thought we shouldn't add Kafka-specific stuff in ray.data
Co-authored-by: Richard Liaw <rliaw@berkeley.edu> Signed-off-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com>
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
## Description - Add kafka user guide in loading data --------- Signed-off-by: You-Cheng Lin <mses010108@gmail.com> Signed-off-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com> Co-authored-by: Richard Liaw <rliaw@berkeley.edu> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
## Description - Add kafka user guide in loading data --------- Signed-off-by: You-Cheng Lin <mses010108@gmail.com> Signed-off-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com> Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
## Description - Add kafka user guide in loading data --------- Signed-off-by: You-Cheng Lin <mses010108@gmail.com> Signed-off-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com> Co-authored-by: Richard Liaw <rliaw@berkeley.edu> Signed-off-by: peterxcli <peterxcli@gmail.com>
3 participants
Description