[Serve][5/n] Add proxy health and request routing delay metrics#59238
Merged
abrarsheikh merged 10 commits intomasterfrom Dec 18, 2025
Merged
[Serve][5/n] Add proxy health and request routing delay metrics#59238abrarsheikh merged 10 commits intomasterfrom
abrarsheikh merged 10 commits intomasterfrom
Conversation
Signed-off-by: abrar <abrar@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several new metrics to improve the observability of Ray Serve. Specifically, it adds a histogram to measure the routing stats propagation delay from replicas to the controller, a gauge to monitor proxy health status, and another gauge to track when a proxy is in a draining state. The changes are implemented across deployment_state.py, proxy.py, and proxy_state.py, and are accompanied by new tests in test_metrics.py and test_metrics_2.py. The implementation is solid and the new metrics are a great addition. I've identified a minor issue in one of the new tests that could lead to flakiness and have suggested a correction.
Signed-off-by: abrar <abrar@anyscale.com>
ray-gardener
bot
added
serve
harshit-anyscale
approved these changes
Dec 17, 2025
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
harshit-anyscale
approved these changes
Dec 18, 2025
Signed-off-by: abrar <abrar@anyscale.com>
akyang-anyscale
approved these changes
Dec 18, 2025
Yicheng-Lu-llll
pushed a commit
to Yicheng-Lu-llll/ray
that referenced
this pull request
Dec 22, 2025
…project#59238) ray-project#59218 --------- Signed-off-by: abrar <abrar@anyscale.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…project#59238) ray-project#59218 --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#59218