[Data] Remove duplicate PhysicalOperator method to get max operator concurrency#59331
Merged
bveeramani merged 1 commit intomasterfrom Dec 10, 2025
Merged
[Data] Remove duplicate PhysicalOperator method to get max operator concurrency#59331bveeramani merged 1 commit intomasterfrom
PhysicalOperator method to get max operator concurrency#59331bveeramani merged 1 commit intomasterfrom
Conversation
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request provides a good cleanup by removing a duplicate method for getting the maximum operator concurrency from the PhysicalOperator base class. The change consolidates max_task_concurrency and another get_max_concurrency_limit into a single get_max_concurrency_limit method. This improves code clarity and maintainability. The implementation is straightforward and correct, and I have no issues to report.
iamjustinhsu
approved these changes
Dec 10, 2025
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
… concurrency (ray-project#59331) ray-project#57788 renamed the `max_task_concurrency()` as `get_max_concurrency_limit()`. However, the PR didn't remove the original ``max_task_concurrency()` method on the `PhysicalOperator` base class (probably an oversight?). This PR fixes the issue by removing the dead method. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#57788 renamed the
max_task_concurrency()asget_max_concurrency_limit(). However, the PR didn't remove the original ``max_task_concurrency()method on thePhysicalOperator` base class (probably an oversight?).This PR fixes the issue by removing the dead method.