Skip to content

[Data] Expose logical operators via package exports#60297

Merged
bveeramani merged 6 commits intoray-project:masterfrom
400Ping:pr/operators
Jan 26, 2026
Merged

[Data] Expose logical operators via package exports#60297
bveeramani merged 6 commits intoray-project:masterfrom
400Ping:pr/operators

Conversation

@400Ping
Copy link
Contributor

@400Ping 400Ping commented Jan 19, 2026

Description

Goal:

Make ray.data._internal.logical.operators a package entry point with short imports and alphabetized __all__.

Changes:

Add/complete all in operator modules and re-export via __init__.py.
Update imports to from ray.data._internal.logical.operators import ....
Keep intra-operator dependencies using module paths to avoid cycles.

Related issues

Related to #60204

Additional information

@400Ping 400Ping requested a review from a team as a code owner January 19, 2026 12:11
@400Ping 400Ping marked this pull request as draft January 19, 2026 12:12
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a nice refactoring that exposes logical operators via a centralized package entry point, which improves code structure and maintainability. The changes are consistent, adding __all__ to operator modules and updating imports throughout the codebase. The dynamic import mechanism in __init__.py is a clean way to achieve this. I have one suggestion to make the dynamic import more robust against future changes.

Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
@400Ping 400Ping changed the title Expose logical operators via package exports [Data] Expose logical operators via package exports Jan 21, 2026
Signed-off-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping 400Ping marked this pull request as ready for review January 26, 2026 02:58
@400Ping
Copy link
Contributor Author

400Ping commented Jan 26, 2026

@bveeramani PTAL

@ray-gardener ray-gardener bot added data Ray Data-related issues community-contribution Contributed by the community labels Jan 26, 2026
@bveeramani
Copy link
Member

nice ty

@bveeramani bveeramani enabled auto-merge (squash) January 26, 2026 23:16
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jan 26, 2026
@bveeramani bveeramani merged commit dfbd727 into ray-project:master Jan 26, 2026
8 checks passed
jinbum-kim pushed a commit to jinbum-kim/ray that referenced this pull request Jan 29, 2026
## Description
### Goal:
Make `ray.data._internal.logical.operator`s a package entry point with
short imports and alphabetized `__all__`.

### Changes:
Add/complete __all__ in operator modules and re-export via
`__init__.py`.
Update imports to from `ray.data._internal.logical.operators import
...`.
Keep intra-operator dependencies using module paths to avoid cycles.

## Related issues
Related to ray-project#60204

## Additional information

---------

Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Co-authored-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
limarkdcunha pushed a commit to limarkdcunha/ray that referenced this pull request Jan 29, 2026
Make `ray.data._internal.logical.operator`s a package entry point with
short imports and alphabetized `__all__`.

Add/complete __all__ in operator modules and re-export via
`__init__.py`.
Update imports to from `ray.data._internal.logical.operators import
...`.
Keep intra-operator dependencies using module paths to avoid cycles.

Related to ray-project#60204

---------

Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Co-authored-by: Jie-Kai Chang <fourhundredping@gmail.com>
400Ping added a commit to 400Ping/ray that referenced this pull request Feb 1, 2026
Make `ray.data._internal.logical.operator`s a package entry point with
short imports and alphabetized `__all__`.

Add/complete __all__ in operator modules and re-export via
`__init__.py`.
Update imports to from `ray.data._internal.logical.operators import
...`.
Keep intra-operator dependencies using module paths to avoid cycles.

Related to ray-project#60204

---------

Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Co-authored-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: 400Ping <jiekaichang@apache.org>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
## Description
### Goal:
Make `ray.data._internal.logical.operator`s a package entry point with
short imports and alphabetized `__all__`.

### Changes:
Add/complete __all__ in operator modules and re-export via
`__init__.py`.
Update imports to from `ray.data._internal.logical.operators import
...`.
Keep intra-operator dependencies using module paths to avoid cycles.

## Related issues
Related to ray-project#60204

## Additional information

---------

Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Co-authored-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
## Description
### Goal:
Make `ray.data._internal.logical.operator`s a package entry point with
short imports and alphabetized `__all__`.

### Changes:
Add/complete __all__ in operator modules and re-export via
`__init__.py`.
Update imports to from `ray.data._internal.logical.operators import
...`.
Keep intra-operator dependencies using module paths to avoid cycles.

## Related issues
Related to ray-project#60204

## Additional information

---------

Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Co-authored-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community data Ray Data-related issues go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants