Conversation
Signed-off-by: nickhil-g <nrg@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a new NVIDIA GPU type, RTX Pro 6000. The change is straightforward, adding a constant for this new accelerator. However, there is a minor inconsistency in the assigned string value for the new constant, which could lead to ambiguity in the future.
| NVIDIA_H20 = "H20" | ||
| NVIDIA_B200 = "B200" | ||
| NVIDIA_B300 = "B300" | ||
| NVIDIA_RTX_PRO_6000 = "RTX" |
There was a problem hiding this comment.
The value assigned to NVIDIA_RTX_PRO_6000 is currently "RTX". This value is quite generic and could lead to ambiguity if other RTX series GPUs are added in the future (e.g., RTX 3090, RTX 4090). For consistency with other specific NVIDIA GPU constants like NVIDIA_A100_40G = "A100-40G", it would be more precise to use a value that reflects the full model name, such as "RTX_PRO_6000" or "RTX6000".
| NVIDIA_RTX_PRO_6000 = "RTX" | |
| NVIDIA_RTX_PRO_6000 = "RTX_PRO_6000" |
| NVIDIA_H20 = "H20" | ||
| NVIDIA_B200 = "B200" | ||
| NVIDIA_B300 = "B300" | ||
| NVIDIA_RTX_PRO_6000 = "RTX" |
There was a problem hiding this comment.
Accelerator type value "RTX" is ambiguous across GPUs
Medium Severity
The value "RTX" assigned to NVIDIA_RTX_PRO_6000 is too generic to serve as a unique identifier for this specific GPU. The auto-detection regex in nvidia_gpu.py (r"\w+\s+([A-Z0-9]+)") extracts only the second word from the NVML device name, so any NVIDIA RTX professional card (e.g., RTX A6000, RTX 6000 Ada) would also produce "RTX". A user requesting NVIDIA_RTX_PRO_6000 could be matched to a completely different RTX GPU. Other constants in this file (like "A100", "H100", "L4") are unique identifiers, but "RTX" is a brand prefix shared across many products.
There was a problem hiding this comment.
I think that's a valid feedback.
If other RTX type GPU also generate the same string, we will update function to get the device type to make the string unique.


Description
Add direct reference for RTX Pro 6000