[Data] Fix operator name in metadata timeout warning and improve mess…#61401
Open
kaveti wants to merge 1 commit intoray-project:masterfrom
Open
[Data] Fix operator name in metadata timeout warning and improve mess…#61401kaveti wants to merge 1 commit intoray-project:masterfrom
kaveti wants to merge 1 commit intoray-project:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the warning message for metadata timeouts in Ray Data. By passing the operator name to DataOpTask, the warning now clearly identifies which pipeline stage is affected, which is a great improvement for debuggability. The warning message itself has been rewritten to be more informative, including the timeout duration and potential causes. The implementation is clean and correctly applied to MapOperator and HashShuffleOperator. The changes look good and improve the user experience.
…age clarity Pass the actual operator name to DataOpTask so the GetTimeoutError warning identifies the specific pipeline stage instead of always showing 'DataOpTask'. Also rewrites the message to include the timeout duration and actionable causes. Fixes ray-project#61334 Signed-off-by: rkaveti <kavetiraviteja1992@gmail.com>
1ef62cd to
507e5ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Data] Fix operator name in metadata timeout warning and improve message clarity
Pass the actual operator name to DataOpTask so the GetTimeoutError warning identifies the specific pipeline stage instead of always showing 'DataOpTask'. Also rewrites the message to include the timeout duration and actionable causes.
Fixes #61334
Description
Related issues
Additional information